Re: [PATCH] arm64: dts: qcom: sm6115: Add interconnect nodes

[Dmitry Baryshkov]

On 30/11/2022 12:45, Bhupesh Sharma wrote:
> Add the interconnect nodes inside SM6115 dtsi.
>
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> ---
> - Based on linux-next/master
> - Depends on the SM6115 dt-binding and driver patchset, which can be
>    seen here: https://lore.kernel.org/linux-arm-msm/20221130103841.2266464-1-bhupesh.sharma@xxxxxxxxxx/
>
>   arch/arm64/boot/dts/qcom/sm6115.dtsi | 51 ++++++++++++++++++++++++++++
>   1 file changed, 51 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index e4a2440ce544..dad5ab3edf0e 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -485,6 +485,57 @@ usb_1_hsphy: phy@1613000 {
>   			status = "disabled";
>   		};
>   
> +		snoc: interconnect@1880000 {
> +			compatible = "qcom,sm6115-snoc";
> +			reg = <0x01880000 0x60200>;
> +			#interconnect-cells = <1>;

Should we use 2 here as we do now for most of interconnect drivers?

> +			clock-names = "bus", "bus_a";
> +			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> +				 <&rpmcc RPM_SMD_SNOC_A_CLK>;

--
With best wishes
Dmitry