Re: [PATCH v1 1/1] usb: acpi: Switch to use acpi_evaluate_dsm_typed()
From: Greg Kroah-Hartman
Date: Thu Jan 19 2023 - 08:13:28 EST
On Wed, Jan 18, 2023 at 10:04:19AM +0200, Andy Shevchenko wrote:
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/core/usb-acpi.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c
> index 533baa85083c..a34b22537d7c 100644
> --- a/drivers/usb/core/usb-acpi.c
> +++ b/drivers/usb/core/usb-acpi.c
> @@ -81,15 +81,11 @@ int usb_acpi_port_lpm_incapable(struct usb_device *hdev, int index)
> return -ENODEV;
> }
>
> - obj = acpi_evaluate_dsm(port_handle, &guid, 0,
> - USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL);
> -
> - if (!obj)
> - return -ENODEV;
> -
> - if (obj->type != ACPI_TYPE_INTEGER) {
> + obj = acpi_evaluate_dsm_typed(port_handle, &guid, 0,
> + USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL,
> + ACPI_TYPE_INTEGER);
> + if (!obj) {
> dev_dbg(&hdev->dev, "evaluate port-%d _DSM failed\n", port1);
> - ACPI_FREE(obj);
> return -EINVAL;
> }
>
> --
> 2.39.0
>
Fails to apply to my tree :(