Re: [PATCH 2/2] clk: mediatek: add MT7981 clock support

[AngeloGioacchino Del Regno]

Il 19/01/23 15:12, Daniel Golle ha scritto:
> Add MT7986 clock support, include topckgen, apmixedsys, infracfg and
> ethernet subsystem clocks.
>
> The drivers are based on clk-mt7981.c which can be found in MediaTek's
> SDK sources. To be fit for upstream inclusion the driver has been split
> into clock domains and the infracfg part has been significantly
> de-bloated by removing all the 1:1 factors (aliases).
>
> Signed-off-by: Jianhui Zhao <zhaojh329@xxxxxxxxx>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> ---
>   drivers/clk/mediatek/Kconfig               |  17 +
>   drivers/clk/mediatek/Makefile              |   4 +
>   drivers/clk/mediatek/clk-mt7981-apmixed.c  | 103 +++++
>   drivers/clk/mediatek/clk-mt7981-eth.c      | 138 +++++++
>   drivers/clk/mediatek/clk-mt7981-infracfg.c | 236 +++++++++++
>   drivers/clk/mediatek/clk-mt7981-topckgen.c | 431 +++++++++++++++++++++
>   include/dt-bindings/clock/mt7981-clk.h     | 215 ++++++++++

dt-bindings go in a different commit; also, please follow binding rules for
filenames... mt7981-clk.h -> mediatek,mt7981-clk.h

>   7 files changed, 1144 insertions(+)
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-apmixed.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-eth.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-infracfg.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-topckgen.c
>   create mode 100644 include/dt-bindings/clock/mt7981-clk.h

Moreover, I have pushed a pretty big cleanup series, which would reduce a bit
the size of the drivers that you're trying to introduce, and which is well
tested and reviewed: can you please rebase this on top of [1]?

Thanks!

[1]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=711734

Regards,
Angelo