Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter()

From: Christoph Hellwig
Date: Thu Jan 19 2023 - 11:47:11 EST


On Thu, Jan 19, 2023 at 10:01:26AM +0000, David Howells wrote:
> Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Which does nothing for places that do not use call_write_iter()...
> > __kernel_write_iter() is one such; for less obvious specimen see
> > drivers/nvme/target/io-cmd-file.c:nvmet_file_submit_bvec()
>
> Should these be calling call_read/write_iter()? If not, should
> call_read/write_iter() be dropped?

I wish they'd just go away, they are a bit of a distraction.