Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node

[Matthias Brugger]

On 17/01/2023 22:39, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote:
> > On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote:
> > > Specify #pwm-cells on pwm@11006000 to make it actually usable.
> > >
> > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes")
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > > index 146e18b5b1f4..f321c6d0fd7c 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > > @@ -435,6 +435,7 @@ uart3: serial@11005000 {
> > >   	pwm: pwm@11006000 {
> > >   		compatible = "mediatek,mt7622-pwm";
> > >   		reg = <0 0x11006000 0 0x1000>;
> > > +		#pwm-cells = <2>;
> >
> > 3 should be possible, too. The driver does only support one
> > polarity, so it's not really needed, but would be nice for consistency?
> >
> > Thierry, what's your take here?
> >
> > Other than that: Who would pick this up, I assume it to go via an ARM
> > tree together with the 2nd patch in this series?

The DT patch should go through my tree once all questions are answered and the 
dt-binding patch got accpeted by PWM maintainer.

Regards,
Matthias

> The questions here are still open and both patches unapplied. :-\
>
> Best regards
> Uwe