Re: [PATCH bpf-next 4/8] bpf: Enable cpumasks to be queried and used as kptrs

From: David Vernet
Date: Thu Jan 19 2023 - 22:39:29 EST


On Fri, Jan 20, 2023 at 10:36:24AM +0800, kernel test robot wrote:
> Hi David,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on bpf-next/master]
>
> url: https://github.com/intel-lab-lkp/linux/commits/David-Vernet/bpf-Enable-annotating-trusted-nested-pointers/20230120-080139
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> patch link: https://lore.kernel.org/r/20230119235833.2948341-5-void%40manifault.com
> patch subject: [PATCH bpf-next 4/8] bpf: Enable cpumasks to be queried and used as kptrs
> config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230120/202301201053.OKCBdOsh-lkp@xxxxxxxxx/config)
> compiler: sparc64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/11541205c58f2226e5ffbc5967317469d65efac6
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review David-Vernet/bpf-Enable-annotating-trusted-nested-pointers/20230120-080139
> git checkout 11541205c58f2226e5ffbc5967317469d65efac6
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash kernel/bpf/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All warnings (new ones prefixed by >>):
>
> >> kernel/bpf/cpumask.c:38:21: warning: no previous prototype for 'bpf_cpumask_create' [-Wmissing-prototypes]
> 38 | struct bpf_cpumask *bpf_cpumask_create(void)

Sorry, also forgot to do the __diag() dance described in [0]. I'll
include that fix in v2.

[0]: https://docs.kernel.org/bpf/kfuncs.html#creating-a-wrapper-kfunc

This is also reminding me to send out the v2 for [1]. I'll do that
after I take care of another few small things I've been putting off.

[1]: https://lore.kernel.org/lkml/20230106195130.1216841-3-void@xxxxxxxxxxxxx/T/

Thanks,
David