Re: [PATCH v4 2/2] mfd: syscon: allow reset control for syscon devices

From: Lee Jones
Date: Fri Jan 20 2023 - 00:34:34 EST


On Thu, 05 Jan 2023, Jeremy Kerr wrote:

> Simple syscon devices may require deassertion of a reset signal in order
> to access their register set. Rather than requiring a custom driver to
> implement this, we can use the generic "resets" specifiers to link a
> reset line to the syscon.
>
> This change adds an optional reset line to the syscon device
> description, and deasserts the reset if detected.
>
> Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> ---
> v2:
> * do reset control in the early of_syscon_register() path, rather than
> the platform device init, which isn't used.
> v3:
> * use a direct reset_control_deassert rather than handling in the
> regmap
> v4:
> * collapse unnecessary `else` block
> ---
> drivers/mfd/syscon.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]