Re: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support

[Krzysztof Kozlowski]

On 20/01/2023 06:25, Richard Zhu wrote:
> Add i.MX8MM PCIe EP support.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 24 +++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 31f4548f85cf..9662aeccdb3b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -1315,6 +1315,30 @@ pcie0: pcie@33800000 {
>  			status = "disabled";
>  		};
>  
> +		pcie0_ep: pcie_ep@33800000 {

No underscores in node names.

> +			compatible = "fsl,imx8mm-pcie-ep";

Did you test it with bindings? Does it pass without warnings?


Best regards,
Krzysztof