Re: [PATCH 2/2] arch: arm64: dts: Add support for AM69 Starter Kit

[Vignesh Raghavendra]

Hi Krzysztof,

On 19/01/23 19:06, Krzysztof Kozlowski wrote:
> On 19/01/2023 14:29, sabiya.d@xxxxxxxxxxxxxxxxxxxx wrote:
>> From: Dasnavis Sabiya <sabiya.d@xxxxxx>
>>
>> AM69 Starter Kit is a single board designed for TI AM69 SOC that
>> provides advanced system integration in automotive ADAS applications,
>> autonomous mobile robot and edge AI applications. The SOC comprises
>> of Cortex-A72s in dual clusters, lockstep capable dual Cortex-R5F MCUs,
>> Vision Processing Accelerators (VPAC) with Image Signal Processor (ISP)
>> and multiple vision assist accelerators, Depth and Motion Processing
>> Accelerators (DMPAC), Deep-learning Matrix Multiply Accelerator(MMA)
>> and C7x floating point vector DSP
>>
>> AM69 SK supports the following interfaces:
>>        * 32 GB LPDDR4 RAM
>>        * x1 Gigabit Ethernet interface
>>        * x3 USB 3.0 Type-A ports
>>        * x1 USB 3.0 Type-C port
>>        * x1 UHS-1 capable micro-SD card slot
>>        * x4 MCAN instances
>>        * 32 GB eMMC Flash
>>        * 512 Mbit OSPI flash
>>        * x2 Display connectors
>>        * x1 PCIe M.2 M Key
>>        * x1 PCIe M.2 E Key
>>        * x1 4L PCIe Card Slot
>>        * x3 CSI2 Camera interface
>>        * 40-pin Raspberry Pi header
>>
>> Add initial support for the AM69 SK board.
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>>
>> Design Files: https://www.ti.com/lit/zip/SPRR466
>> TRM: https://www.ti.com/lit/zip/spruj52
>>
>> Signed-off-by: Dasnavis Sabiya <sabiya.d@xxxxxx>
>> ---
>>  arch/arm64/boot/dts/ti/Makefile       |   1 +
>>  arch/arm64/boot/dts/ti/k3-am69-sk.dts | 180 ++++++++++++++++++++++++++
>>  2 files changed, 181 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/ti/k3-am69-sk.dts
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index e7c2c7dd0b25..04b1a7611096 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb
>>  
>>  dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>>  
>> +dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
> 
> I was told the order of entries here is "time of release". Is it
> correct? This is the order you want to keep here and am69-sk was
> released after j721s2-common-proc-board but before j784s4-evm?


Unfortunately, files are not in any particular order at the moment.

Currently, entries are grouped into a block based upon SoC present on
them. Boards within the family block are sorted alphabetically. But the
block of SoCs itself is arranged in no particular order.

I would like to propose to cleanup this file such that board dtbs are
grouped as per SoC present on them (like now), sort the group
alphabetically. Also then sort alphabetically within the family (similar
how boards appear in dt bindings)

Will do that towards end of rc6 once these patches are queued up to
avoid merge conflicts.

> 
>>  dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb
>>  
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Regards
Vignesh