Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile

[Sedat Dilek]

On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 1/20/23 09:11, Sedat Dilek wrote:
> > On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@xxxxxxx> wrote:
> >>
> >> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
> >>> Revert the portion of a recent Makefile change that incorrectly
> >>> deletes source files when doing "make clean".
>
> Ooo. That is bad.
>
> >>>
> >>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> >>> Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> >>> Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> >>> Signed-off-by: Doug Smythies <dsmythies@xxxxxxxxx>
> >>
> >> (+ Shuah and linux-kselftest mailing list)
> >>
> >> Thanks for fix!
> >>
> >> Acked-by: Huang Rui <ray.huang@xxxxxxx>
> >>
> >
> > [ I already replied - but with these important CCs ]
> >
> > Hi Doug,
> >
> > Thanks for the patch!
> >
> > Small nit, I saw this with:
>
> What did you see and should that be fixed as well.
>
> >
> > $ make -C tools/ clean
> >
> > Otherwise:
> >
> > Reviewed-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> >
>
> Send me the revised patch with all the right CCs and I will pull
> this right away.
>

Hi Shuah,

that was my original posting...

Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean
https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@xxxxxxxxxxxxxx/

...and should contain all CCs I got with scripts/get_maintainer.pl.

Is that OK?

BR,
-Sedat-