Re: [PATCH v6 16/17] qcom: llcc/edac: Support polling mode for ECC handling

[Borislav Petkov]

On Wed, Jan 18, 2023 at 08:39:03PM +0530, Manivannan Sadhasivam wrote:
> Not all Qcom platforms support IRQ mode for ECC handling. For those
> platforms, the current EDAC driver will not be probed due to missing ECC
> IRQ in devicetree.
> 
> So add support for polling mode so that the EDAC driver can be used on all
> Qcom platforms supporting LLCC.
> 
> The polling delay of 5000ms is chosen based on Qcom downstream/vendor
> driver.
> 
> Reported-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> Tested-by: Steev Klimaszewski <steev@xxxxxxxx> # Thinkpad X13s
> Tested-by: Andrew Halaney <ahalaney@xxxxxxxxxx> # sa8540p-ride
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>  drivers/edac/qcom_edac.c     | 50 +++++++++++++++++++++---------------
>  drivers/soc/qcom/llcc-qcom.c | 13 +++++-----
>  2 files changed, 35 insertions(+), 28 deletions(-)

Reviewed-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette