Re: [PATCH] ntfs3: Fix attr_punch_hole() null pointer derenference

From: Greg KH
Date: Sun Jan 22 2023 - 08:46:36 EST


On Tue, Jan 17, 2023 at 08:21:36PM +0000, SeongJae Park wrote:
> Hello,
>
> On Mon, 15 Aug 2022 14:07:12 +0300 Alon Zahavi <zahavi.alon@xxxxxxxxx> wrote:
>
> > From: Alon Zahavi <zahavi.alon@xxxxxxxxx>
> >
> > The bug occours due to a misuse of `attr` variable instead of `attr_b`.
> > `attr` is being initialized as NULL, then being derenfernced
> > as `attr->res.data_size`.
> >
> > This bug causes a crash of the ntfs3 driver itself,
> > If compiled directly to the kernel, it crashes the whole system.
> >
> > Signed-off-by: Alon Zahavi <zahavi.alon@xxxxxxxxx>
> > Co-developed-by: Tal Lossos <tallossos@xxxxxxxxx>
> > Signed-off-by: Tal Lossos <tallossos@xxxxxxxxx>
>
> This patch has now merged in mainline as
> 6d5c9e79b726cc473d40e9cb60976dbe8e669624. stable@, could you please merge this
> in stable kernels?
>
> Fixes: be71b5cba2e64 ("fs/ntfs3: Add attrib operations") # 5.14
>

Now queued up, thanks.

greg k-h