Re: [PATCH RFC v7 24/64] crypto:ccp: Define the SEV-SNP commands

[Sabin Rapan]

On 14.12.2022 21:40, Michael Roth wrote:
> From: Brijesh Singh <brijesh.singh@xxxxxxx>
> 
> +/*
> + * struct sev_user_data_snp_config - system wide configuration value for SNP.
> + *
> + * @reported_tcb: The TCB version to report in the guest attestation report.
> + * @mask_chip_id: Indicates that the CHID_ID field in the attestation report
> + * will always be zero.
> + */
> +struct sev_user_data_snp_config {
> +       __u64 reported_tcb;     /* In */
> +       __u32 mask_chip_id;     /* In */
> +       __u8 rsvd[52];
> +} __packed;
> +

Based on table 45 section 8.6.1 in
https://www.amd.com/system/files/TechDocs/56860.pdf I think this should be 

struct sev_user_data_snp_config {
       __u64 reported_tcb;     /* In */
       __u32 mask_chip_id:1;     /* In */
       __u32 mask_chip_key:1;     /* In */
       __u32 rsvd:30;
       __u8 rsvd1[52];
} __packed;


--
Sabin.



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.