Re: [PATCH v2] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting

[Wolfram Sang]

Hi Krzysztof,

> > +static const struct soc_device_attribute rpcif_info_match[]  = {
> > +	{ .soc_id = "r8a7795", .revision = "ES1.*", .data = &rpcif_info_r8a7795_es1 },
> > +	{ .soc_id = "r8a7796", .revision = "ES1.*", .data = &rpcif_info_r8a7796_es1 },
> 
> Why do you need soc match? Can't this be inferred from device
> compatible? Maybe the device compatible is not specific enough? Devices
> should not be interested in which SoC they are running - it does not
> matter for them, because the device difference is in the device itself,
> not in the SoC (different SoCs come with different devices).

I need it because of ".revision". This only applies to "ES1.*",
there are "ES2.*" and "ES3.*" around which have the same SoC number.
Also, there is usually no version numbering for the IP core. We need to
use this scheme in a number of other places already, sadly.

Thanks for reviewing,

   Wolfram

Attachment: signature.asc
Description: PGP signature