Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

[Andy Shevchenko]

On Sun, Jan 22, 2023 at 05:24:41PM +0000, Jonathan Cameron wrote:
> On Wed, 18 Jan 2023 12:06:23 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> > The node name can contain an address part which is unused
> > by the driver. Moreover, this string is propagated into
> > the userspace label, sysfs filenames *and breaking ABI*.
> > 
> > Cut the address part out before assigning the channel name.
> > 
> > Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
> > Reported-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> LGTM, but given it will have ABI impact, I'd like to hear from 
> Andy, Bjorn or Konrad as maintainers and /or Dmitry as someone
> who has touched this driver fairly recently.

Hmm... But this is to fix the ABI breakage. It means that the previous series
by Nuno had broken it.

> Mostly I want to be sure they know this exists before it causes surprise.

-- 
With Best Regards,
Andy Shevchenko