Re: [PATCH 3/3] ptrace,syscall_user_dispatch: add a getter/setter for sud configuration
From: Andrei Vagin
Date: Mon Jan 23 2023 - 21:51:30 EST
On Sun, Jan 22, 2023 at 8:22 PM Gregory Price <gourry.memverge@xxxxxxxxx> wrote:
<snip>
>
> +#define PTRACE_SET_SYSCALL_USER_DISPATCH_CONFIG 0x4210
> +#define PTRACE_GET_SYSCALL_USER_DISPATCH_CONFIG 0x4211
> +struct syscall_user_dispatch_config {
> + __u64 mode;
> + __s8 *selector;
> + __u64 offset;
> + __u64 len;
> + __u8 on_dispatch;
Sorry, I didn't notice this in the previous version. on_dispatch looks
like an internal
property and I don't see how we can stop a process with ptrace when on_dispatch
is set to a non-zero value. I am not sure that we need to expose it to
user-space.
Other than that, the patch looks good to me.
Thanks,
Andrei