Re: [RFC PATCH 02/19] drivers/vhost: Convert to use vm_account

From: Michael S. Tsirkin
Date: Tue Jan 24 2023 - 00:57:23 EST


On Tue, Jan 24, 2023 at 04:42:31PM +1100, Alistair Popple wrote:
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index ec32f78..a31dd53 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c

...

> @@ -780,6 +780,10 @@ static int vhost_vdpa_map(struct vhost_vdpa *v, struct vhost_iotlb *iotlb,
> u32 asid = iotlb_to_asid(iotlb);
> int r = 0;
>
> + if (!vdpa->use_va)
> + if (vm_account_pinned(&dev->vm_account, PFN_DOWN(size)))
> + return -ENOMEM;
> +
> r = vhost_iotlb_add_range_ctx(iotlb, iova, iova + size - 1,
> pa, perm, opaque);
> if (r)

I suspect some error handling will have to be reworked then, no?

> --
> git-series 0.9.1