Re: [PATCH v4 net-next 04/12] net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)

[Vladimir Oltean]

On Mon, Jan 23, 2023 at 10:30:33PM -0800, Jakub Kicinski wrote:
> On Tue, 24 Jan 2023 07:20:20 +0100 Eric Dumazet wrote:
> > >  static int pause_prepare_data(const struct ethnl_req_info *req_base,
> > >                               struct ethnl_reply_data *reply_base,
> > >                               struct genl_info *info)
> > >  {
> > > +       const struct pause_req_info *req_info = PAUSE_REQINFO(req_base);
> > >         struct pause_reply_data *data = PAUSE_REPDATA(reply_base);
> > > +       enum ethtool_mac_stats_src src = req_info->src;
> > > +       struct netlink_ext_ack *extack = info->extack;  
> > 
> > info can be NULL when called from ethnl_default_dump_one()
> 
> Second time in a month, I think..
> 
> Should we make a fake info to pass here? (until someone finds the time 
> to combine the do/dump infos more thoroughly, at least)

Thanks for letting me know. I've sent 2 patches that fix this for
ETHTOOL_MSG_PAUSE_GET and for ETHTOOL_MSG_STATS_GET:
https://patchwork.kernel.org/project/netdevbpf/patch/20230124110801.3628545-1-vladimir.oltean@xxxxxxx/
https://patchwork.kernel.org/project/netdevbpf/patch/20230124111328.3630437-1-vladimir.oltean@xxxxxxx/