Re: [PATCH v8 07/10] block: Switch to pinning pages.

From: Christoph Hellwig
Date: Tue Jan 24 2023 - 11:45:13 EST


On Tue, Jan 24, 2023 at 03:03:53PM +0000, David Howells wrote:
> Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > It can't. Per your latest branch:
>
> Yes it can. Patch 6:

This never involves the cleanup mode as input. And as I pointed out
in the other mail, there is no need for the FOLL_ flags on the
cleanup side. You can just check the bio flag in bio_release_apges
and call either put_page or unpin_user_page on that. The direct
callers of bio_release_page never mix them pin and get cases anyway.
Let me find some time to code this up if it's easier to understand
that way.