Re: [PATCH AUTOSEL 6.1 15/35] btrfs: stop using write_one_page in btrfs_scratch_superblock

From: David Sterba
Date: Tue Jan 24 2023 - 12:04:01 EST


On Tue, Jan 24, 2023 at 08:41:11AM -0500, Sasha Levin wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> [ Upstream commit 26ecf243e407be54807ad67210f7e83b9fad71ea ]
>
> write_one_page is an awkward interface that expects the page locked and
> ->writepage to be implemented. Replace that by zeroing the signature
> bytes and synchronize the block device page using the proper bdev
> helpers.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: David Sterba <dsterba@xxxxxxxx>
> [ update changelog ]
> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Please drop this patch and "btrfs: factor out scratching of one regular
super block" from all stable queues. It's not a fix, only preparatory
work to allow removing write_one_page from MM code.

Commit ids: 0e0078f72be81bbb and 26ecf243e407be54