Re: [PATCH v9 6/8] block: Switch to pinning pages.

[David Howells]

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > Add BIO_PAGE_PINNED to indicate that the pages in a bio are pinned
> > (FOLL_PIN) and that the pin will need removing.
> 
> The subject is odd when this doesn't actually switch anything,
> but just adds the infrastructure to unpin pages.

How about:

	block: Add BIO_PAGE_PINNED and associated infrastructure

> > +static inline void bio_set_cleanup_mode(struct bio *bio, struct iov_iter *iter)
> ...
> At this point I'd be tempted to just open code these two lines
> instead of adding a helper, but I can live with the helper if you
> prefer it.

I can do that.  It makes sense to put the call to that next to the call to
iov_iter_extract_pages().

David