Re: [PATCH 2/2] bpf/tracing: Use stage6 of tracing to not duplicate macros
From: Alexei Starovoitov
Date: Tue Jan 24 2023 - 16:11:56 EST
On Tue, Jan 24, 2023 at 12:25 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
>
> The bpf events are created by the same macro magic as tracefs trace
> events are. But to hook into bpf, it has its own code. It duplicates many
> of the same macros as the tracefs macros and this is an issue because it
> misses bug fixes as well as any new enhancements that come with the other
> trace macros.
>
> As the trace macros have been put into their own staging files, have bpf
> take advantage of this and use the tracefs stage 6 macros that the "fast
> ssign" portion of the trace event macro uses.
>
> Link: https://lore.kernel.org/lkml/1671181385-5719-1-git-send-email-quic_linyyuan@xxxxxxxxxxx/
>
> Cc: bpf@xxxxxxxxxxxxxxx
> Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
> Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
> Reported-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx>
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
Nice cleanup.
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>