Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map"

[Rob Herring]

On Tue, Jan 24, 2023 at 03:02:54PM -0800, Isaac J. Manjarres wrote:
> This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769.
> 
> Kmemleak operates by periodically scanning memory regions for pointers
> to allocated memory blocks to determine if they are leaked or not.
> However, reserved memory regions can be used for DMA transactions
> between a device and a CPU, and thus, wouldn't contain pointers to
> allocated memory blocks, making them inappropriate for kmemleak to
> scan. Thus, revert this commit.

Both commits talk about the same type of memory as CMA is used for DMA. 
Neither commit tells me what are the implications of kmemleak scanning 
or not scanning the region? Are there false positives?

> Cc: stable@xxxxxxxxxxxxxxx # 5.17+
> Cc: Calvin Zhang <calvinzhang.cool@xxxxxxxxx>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@xxxxxxxxxx>
> ---
>  drivers/of/fdt.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)