Re: [PATCH] x86/ACPI/boot: use try_cmpxchg in __acpi_{acquire,release}_global_lock

[Rafael J. Wysocki]

On Thu, Jan 26, 2023 at 11:48 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> > On Mon, Jan 16, 2023 at 5:25 PM Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
> > >
> > > Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
> > > __acpi_{acquire,release}_global_lock.  x86 CMPXCHG instruction returns
> > > success in ZF flag, so this change saves a compare after cmpxchg
> > > (and related move instruction in front of cmpxchg).
> > >
> > > Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
> > > fails. There is no need to re-read the value in the loop.
> > >
> > > Note that the value from *ptr should be read using READ_ONCE to prevent
> > > the compiler from merging, refetching or reordering the read.
> > >
> > > No functional change intended.
> > >
> > > Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> > > Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> > > Cc: Len Brown <len.brown@xxxxxxxxx>
> > > Cc: Pavel Machek <pavel@xxxxxx>
> > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> > > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> >
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > but please CC linux-acpi on all ACPI-related changes in the future.
>
> Thanks Rafael - I'll take this patch through the locking tree, if that's
> fine with you.

It is, thanks!