Re: [PATCH v1 5/5] gpio: Clean up headers
From: Andy Shevchenko
Date: Thu Jan 26 2023 - 07:16:19 EST
On Thu, Jan 26, 2023 at 11:22:00AM +0100, Linus Walleij wrote:
> On Wed, Jan 25, 2023 at 9:10 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > There is a few things done:
> > - include only the headers we are direct user of
> > - when pointer is in use, provide a forward declaration
> > - add missing headers
> > - group generic headers and subsystem headers
> > - sort each group alphabetically
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Just to add to the confusion I was also pursuing a series of cleanups directed
> at just removing <linux/gpio/driver.h> from <linux/gpio.h>:
> https://lore.kernel.org/linux-gpio/CACRpkdb6yMqTkrJOg+K46RZ1478-gbxh6=tw4bzWmd--5nj_Bw@xxxxxxxxxxxxxx/
>
> Right now I don't know what to do :D
I saw your series and find them very good!
Can we have them applied?
Arnd's one probably also needs to be considered sooner.
This one can be postponed.
--
With Best Regards,
Andy Shevchenko