Re: [PATCH] ASoC: cs42l56: fix DT probe
From: Mark Brown
Date: Thu Jan 26 2023 - 10:33:07 EST
On Thu, Jan 26, 2023 at 02:46:35PM +0000, Charles Keepax wrote:
> On Thu, Jan 26, 2023 at 02:03:35PM +0000, Mark Brown wrote:
> > Or there is no mandatory properties/platform data and the
> > defaults are fine for most systems (which is a common case).
> I think Arnd is right here, the driver appears to allocate a big
> block of zeros and then blat that over the top of everything it
> read from device tree. So you can literally never use any of the
> DT properties as it stands.
Oh, the fix is fixing a real issue - it's the claim in the commit
log that the driver could never have worked that's not obviously
correct.
Attachment:
signature.asc
Description: PGP signature