Re: [PATCH v5 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description
From: Mike Rapoport
Date: Thu Jan 26 2023 - 14:36:24 EST
On Thu, Jan 26, 2023 at 11:19:16AM -0700, Jonathan Corbet wrote:
> Mike Rapoport <rppt@xxxxxxxxxx> writes:
>
> > From: "Mike Rapoport (IBM)" <rppt@xxxxxxxxxx>
> >
> > Add structure, introduction and Nodes section to Physical Memory
> > chapter.
> >
> > As the new documentation references core-api/dma-api and mm/page_reclaim,
> > add page labels to those documents.
> >
> > Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
> > Reviewed-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
> > Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> > Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> > Signed-off-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>
>
> I've gone ahead and applied this, but I do have one little gripe...
>
> Something like:
>
> > +Reclaim control
> > +~~~~~~~~~~~~~~~
> > +
> > +See also :ref:`Page Reclaim <page_reclaim>`.
>
> Can also just be "See also Documentation/mm/page_reclaim.rst". The
> right things will happen in the HTML output, readers of the plain-text
> will know immediately where to go, and we don't have to add the label
> clutter.
>
> </gripe> :)
Do you want v6? ;-)
> Thanks,
>
> jon
--
Sincerely yours,
Mike.