Re: [PATCH] fsi: Add aliased device numbering

From: Jeremy Kerr
Date: Thu Jan 26 2023 - 20:05:49 EST


Hi Eddie,

> The I2C and SPI subsystems can use an aliased name to number the
> device. Add similar support to the FSI subsystem for any device type.

Sounds good!

However, the majority of this patch seems to be the change to a (const)
enum value, which you then convert to a string to generate the
non-number component of the device name.

Does:

       dev_set_name(&scom->dev, "%s%d", fsi_get_dev_type_name(fsi_dev_scom), didx);

have much of a benefit over:

       dev_set_name(&scom->dev, "scom%d", didx);

?

Cheers,


Jeremy