Re: [PATCH] efivarfs: fix NULL-deref on mount when no efivars

From: Johan Hovold
Date: Fri Jan 27 2023 - 03:28:17 EST


On Thu, Jan 26, 2023 at 09:32:27PM +0100, Ard Biesheuvel wrote:
> On Thu, 26 Jan 2023 at 12:23, Johan Hovold <johan+linaro@xxxxxxxxxx> wrote:
> >
> > The VFS calls kill_sb() also in case mount fails in get_tree().
> >
> > Add the missing check to make sure that efivars has been registered also
> > to kill_sb() to avoid dereferencing a NULL pointer when trying to remove
> > efivar entries.
> >
> > Fixes: c3fd71b428b8 ("efivarfs: always register filesystem")
> > Reported-by: Steev Klimaszewski <steev@xxxxxxxx>
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
>
> Thanks - I have squashed this with the original patch.

Thanks, Ard. And sorry about not catching this before posting.

Johan