Re: [PATCH 5/6] dt-bindings: mailbox: Add compatible for IPQ9574

[Devi Priya]

On 1/13/2023 8:43 PM, Konrad Dybcio wrote:
> On 13.01.2023 15:36, devi priya wrote:
> > Add the mailbox compatible string for IPQ9574 SoC
> >
> > Co-developed-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> Binding changes should come before driver changes, so that
> you're not introducing an "illegal" compatible and only
> "legalize" it later - please reorder the patch.
>
> Konrad
Understood, will reorder the patches in V2
> >   .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml     | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > index 943f9472ae10..9e076758a58a 100644
> > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > @@ -20,6 +20,7 @@ properties:
> >             - enum:
> >                 - qcom,ipq6018-apcs-apps-global
> >                 - qcom,ipq8074-apcs-apps-global
> > +              - qcom,ipq9574-apcs-apps-global
> >                 - qcom,msm8976-apcs-kpss-global
> >                 - qcom,msm8996-apcs-hmss-global
> >                 - qcom,msm8998-apcs-hmss-global
> > @@ -113,6 +114,7 @@ allOf:
> >             enum:
> >               - qcom,ipq6018-apcs-apps-global
> >               - qcom,ipq8074-apcs-apps-global
> > +            - qcom,ipq9574-apcs-apps-global
> >       then:
> >         properties:
> >           clocks:
> > @@ -129,6 +131,7 @@ allOf:
> >             enum:
> >               - qcom,ipq6018-apcs-apps-global
> >               - qcom,ipq8074-apcs-apps-global
> > +            - qcom,ipq9574-apcs-apps-global
> >       then:
> >         properties:
> >           '#clock-cells':
Best Regards,
Devi Priya