RE: [PATCH 04/11] ARM: dts: exynos: align pin node names in Exynos4412

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; Inki Dae <inki.dae@xxxxxxxxxxx>; Kyungmin
> Park <kyungmin.park@xxxxxxxxxxx>; Kukjin Kim <kgene@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: replicant@xxxxxxxxxx; phone-devel@xxxxxxxxxxxxxxx;
> ~postmarketos/upstreaming@xxxxxxxxxxx; Martin Jücker
> <martin.juecker@xxxxxxxxx>; Henrik Grimler <henrik@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 04/11] ARM: dts: exynos: align pin node names in
> Exynos4412
> 
> The DT schema expect pin configuration nodes to have pin prefix or
> suffix:
> 
>   exynos4412-trats2.dtb: pinctrl@3860000: sleep-state: 'gpz-0', 'gpz-1', 'gpz-2',
> 'gpz-3', 'gpz-4', 'gpz-5', 'gpz-6'
>     do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$',
> 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

>  arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> index 58847d4fa846..8ab31c3daa48 100644
> --- a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> @@ -12,7 +12,7 @@
>  #include "exynos-pinctrl.h"
> 
>  #define PIN_SLP(_pin, _mode, _pull)					\
> -	_pin {								\
> +	pin- ## _pin {							\
>  		samsung,pins = #_pin;					\
>  		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_ ##_mode>;
> 	\
>  		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_ ##_pull>;
> 	\
> --
> 2.34.1