RE: [PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; Inki Dae <inki.dae@xxxxxxxxxxx>; Kyungmin
> Park <kyungmin.park@xxxxxxxxxxx>; Kukjin Kim <kgene@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: replicant@xxxxxxxxxx; phone-devel@xxxxxxxxxxxxxxx;
> ~postmarketos/upstreaming@xxxxxxxxxxx; Martin Jücker
> <martin.juecker@xxxxxxxxx>; Henrik Grimler <henrik@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 09/11] ARM: dts: exynos: correct SATA clocks in Exynos5250
> 
> The DT schema expects clock name matching certain patterns:
> 
>   exynos5250-smdk5250.dtb: sata@122f0000: clock-names:1: 'oneOf'
> conditional failed, one must be fixed:
>     'sclk_sata' is not one of ['pclk', 'aclk', 'hclk', 'sata']
>     'pmalive' was expected
>     'rxoob' was expected
>     'ref' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


>  arch/arm/boot/dts/exynos5250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index f82f82fc803f..9225f3552837 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -390,7 +390,7 @@ sata: sata@122f0000 {
>  			reg = <0x122F0000 0x1ff>;
>  			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clock CLK_SATA>, <&clock
> CLK_SCLK_SATA>;
> -			clock-names = "sata", "sclk_sata";
> +			clock-names = "sata", "pclk";
>  			phys = <&sata_phy>;
>  			phy-names = "sata-phy";
>  			ports-implemented = <0x1>;
> --
> 2.34.1