Re: [PATCH] platform/x86: dell-smo8800: Use min_t() for comparison and assignment

From: Pali Rohár
Date: Sat Jan 28 2023 - 09:02:39 EST


On Friday 27 January 2023 22:01:49 Deepak R Varma wrote:
> Simplify code by using min_t helper macro for logical evaluation
> and value assignment. Use the _t variant of min macro since the
> variable types are not same.
> This issue is identified by coccicheck using the minmax.cocci file.
>
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>

Looks good,

Acked-by: Pali Rohár <pali@xxxxxxxxxx>

> ---
> drivers/platform/x86/dell/dell-smo8800.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/dell-smo8800.c b/drivers/platform/x86/dell/dell-smo8800.c
> index 3385e852104c..8d6b7a83cf24 100644
> --- a/drivers/platform/x86/dell/dell-smo8800.c
> +++ b/drivers/platform/x86/dell/dell-smo8800.c
> @@ -67,10 +67,7 @@ static ssize_t smo8800_misc_read(struct file *file, char __user *buf,
>
> retval = 1;
>
> - if (data < 255)
> - byte_data = data;
> - else
> - byte_data = 255;
> + byte_data = min_t(u32, data, 255);
>
> if (put_user(byte_data, buf))
> retval = -EFAULT;
> --
> 2.34.1
>
>
>