RE: [PATCH v1 1/1] lib/string: Use strchr() in strpbrk()

[David Laight]

From: Andy Shevchenko
> Sent: 27 January 2023 15:52
> 
> Use strchr() instead of open coding it as it's done elsewhere in
> the same file. Either we will have similar to what it was or possibly
> better performance in case architecture implements its own strchr().

Except that you get a whole load of calls to strchr() for (typically)
very few characters.
So the cost of the calls dominates, anything that tries to speed up
strchr() for long strings will also slow things down.

Plausibly this version (untested) is faster!

char *strbprk(const char *str, const char *seps)
{
	const char *found, *try;

	do {
		if (*!seps)
			return NULL;
		found = strchr(str, *seps++);
	} while (!found);

	while (*seps) {
		try = memchr(str, *seps++, found - str);
		if (try)
			found = try;
	}

	return (char *)found;
}

Although I very much doubt strpbrk() is used anywhere where
performance matters.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)