Re: [PATCH V1 3/8] dt-bindings: pinctrl: qcom: Document IPQ9574 pinctrl driver

[Devi Priya]

On 1/25/2023 4:37 PM, Krzysztof Kozlowski wrote:
> On 24/01/2023 15:15, devi priya wrote:
> > Document the pinctrl driver for IPQ9574
> >
> > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   .../bindings/pinctrl/qcom,ipq9574-tlmm.yaml   | 135 ++++++++++++++++++
> >   1 file changed, 135 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq9574-tlmm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq9574-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq9574-tlmm.yaml
> > new file mode 100644
> > index 000000000000..d736f0fb7835
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq9574-tlmm.yaml
> > @@ -0,0 +1,135 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq9574-tlmm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Technologies, Inc. IPQ9574 TLMM block
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@xxxxxxxxxx>
> > +  - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > +
> > +description:
> > +  Top Level Mode Multiplexer pin controller in Qualcomm IPQ9574 SoC.
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,ipq9574-tlmm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts: true
>
> Also - missing maxItems.
>
> I think you based your patches on some older version, so you might miss
> here changes we did recently.
Sure, will rebase it on linux-next and post V3
> Best regards,
> Krzysztof
Best Regards,
Devi Priya