RE: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support

[Hongxing Zhu]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 2023年1月20日 16:08
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; Peng Fan
> <peng.fan@xxxxxxx>; marex@xxxxxxx; Marcel Ziswiler
> <marcel.ziswiler@xxxxxxxxxxx>; tharvey@xxxxxxxxxxxxx; Frank Li
> <frank.li@xxxxxxx>
> Cc: lorenzo.pieralisi@xxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support
> 
> On 20/01/2023 06:25, Richard Zhu wrote:
> > Add i.MX8MM PCIe EP support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 24
> +++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 31f4548f85cf..9662aeccdb3b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -1315,6 +1315,30 @@ pcie0: pcie@33800000 {
> >  			status = "disabled";
> >  		};
> >
> > +		pcie0_ep: pcie_ep@33800000 {
> 
> No underscores in node names.
Hi Krzystof:
Thanks for your review comments.
Sorry to reply late, since I'm taking the Spring Festival Vacation in the past days.
Got that. Would be changed later.
> 
> > +			compatible = "fsl,imx8mm-pcie-ep";
> 
> Did you test it with bindings? Does it pass without warnings?
> 
> 
It's my fault that I'm trying to let fsl,imx6q-pcie.yaml to cover the binding
DT-schema for the Endpoint modes.

One standalone fsl,imx6q-pcie-ep.yaml should be created as DT-schema for i.MX
PCIe Endpoint modes.

I would summit next version a moment later. Please help to review them.
Thanks in advanced.

Best Regards
Richard Zhu

> Best regards,
> Krzysztof