Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support

[Steve French]

On Sun, Jan 29, 2023 at 7:57 PM Namjae Jeon <linkinjeon@xxxxxxxxxx> wrote:
>
> 2023-01-30 9:01 GMT+09:00, Steve French <smfrench@xxxxxxxxx>:
> Hi Steve,
>
> > Fix indentation of server config options, and also since
> > support for very old, less secure, NTLM authentication was removed
> > (and quite a while ago), remove the mention of that in Kconfig, but
> > do note Kerberos (not just NTLMv2) which are supported and much
> > more secure.
> >
> > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> > ---
> >  fs/ksmbd/Kconfig | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> > index e1fe17747ed6..4153e5491435 100644
> > --- a/fs/ksmbd/Kconfig
> > +++ b/fs/ksmbd/Kconfig
> > @@ -33,17 +33,18 @@ config SMB_SERVER
> >     in ksmbd-tools, available from
> >     https://github.com/cifsd-team/ksmbd-tools.
> >     More detail about how to run the ksmbd kernel server is
> > -   available via README file
> > +   available via the README file
> >     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
> >
> >     ksmbd kernel server includes support for auto-negotiation,
> >     Secure negotiate, Pre-authentication integrity, oplock/lease,
> >     compound requests, multi-credit, packet signing, RDMA(smbdirect),
> >     smb3 encryption, copy-offload, secure per-user session
> > -   establishment via NTLM or NTLMv2.
> > +   establishment via Kerberos or NTLMv2.
> >
> >  config SMB_SERVER_SMBDIRECT
> >   bool "Support for SMB Direct protocol"
> > + depends on SMB_SERVER
> I am wondering this change is needed in this patch ? There is no patch
> description for this change...

The "depends on SMB_SERVER" is needed to fix the indentation -
otherwise it thinks that "config SMB_SERVER_DIRECT" is at the same
level of indentation as its parent (ksmbd)
See before and after screenshots attached.



-- 
Thanks,

Steve

Attachment: image.png
Description: PNG image

Attachment: image.png
Description: PNG image