Re: [PATCH 6/7] arm64: dts: qcom: sm8550-mtp: add pmic glink node

[Neil Armstrong]

On 30/01/2023 11:41, Konrad Dybcio wrote:
> On 30.01.2023 10:54, Neil Armstrong wrote:
> > Add the pmic glink node linked with the DWC3 USB controller
> > switched to OTG mode and tagged with usb-role-switch.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 34 ++++++++++++++++++++++++++++++++-
> >   1 file changed, 33 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > index 725d3bc3ee72..f054c11fe1f6 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> > @@ -27,6 +27,31 @@ chosen {
> >   		stdout-path = "serial0:115200n8";
> >   	};
> >   
> > +	pmic-glink {
> > +		compatible = "qcom,sm8450-pmic-glink",
> 8550?
>
> Otherwise same comments as for the previous patch

Oops bad copy-pasta even if it still works...

Thanks,
Neil

> Konrad
> "qcom,pmic-glink";
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		connector@0 {
> > +			compatible = "usb-c-connector";
> > +			reg = <0>;
> > +			power-role = "dual";
> > +			data-role = "dual";
> > +
> > +			ports {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				port@0 {
> > +					reg = <0>;
> > +					pmic_glink_dwc3_in: endpoint {
> > +						remote-endpoint = <&usb_1_dwc3_out>;
> > +					};
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> >   	vph_pwr: vph-pwr-regulator {
> >   		compatible = "regulator-fixed";
> >   		regulator-name = "vph_pwr";
> > @@ -546,7 +571,14 @@ &usb_1 {
> >   };
> >   
> >   &usb_1_dwc3 {
> > -	dr_mode = "peripheral";
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +
> > +	port {
> > +		usb_1_dwc3_out: endpoint {
> > +		      remote-endpoint = <&pmic_glink_dwc3_in>;
> > +	      };
> > +	};
> >   };
> >   
> >   &usb_1_hsphy {