Re: [PATCH v4 1/5] dt-bindings: hwmon: adi,ltc2945: Add binding

From: Jon Cormier
Date: Mon Jan 30 2023 - 10:19:35 EST


On Sun, Jan 29, 2023 at 3:16 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Thu, Jan 26, 2023 at 05:32:23PM -0500, Jonathan Cormier wrote:
> > Create initial binding for the LTC2945 I2C power monitor.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
>
> Series applied,
Great
> after merging patch 4/5 and 5/5 of the series
> to avoid spurious 32-bit build failures,
Huh, I split these per request, curious why they'd cause build
failures when separated...
> and after fixing a continuation line alignment.
>
> In the future, please run checkpatch --strict on your patches,
Will do. I didn't know about this option.
> and please provide change logs.
This I did do in every cover letter.
>
> Thanks,
> Guenter

--
Jonathan Cormier
Software Engineer

Voice: 315.425.4045 x222



http://www.CriticalLink.com
6712 Brooklawn Parkway, Syracuse, NY 13211