Re: [PATCH v2 8/8] iommu: Clean up open-coded ownership checks

From: Jason Gunthorpe
Date: Mon Jan 30 2023 - 12:10:47 EST


On Thu, Jan 26, 2023 at 06:26:23PM +0000, Robin Murphy wrote:
> Some drivers already implement their own defence against the possibility
> of being given someone else's device. Since this is now taken care of by
> the core code (and via a slightly different path from the original
> fwspec-based idea), let's clean them up.
>
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
> ---
>
> v2: No change, but I'll note here that it's really about the fwspec->ops
> checks; the !fwspec clauses are just going along for the ride where
> that's clearly impossible as well. I plan to sweep for other
> redundant checks in future when looking at the relevant flows.

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason