Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

From: Rob Herring
Date: Mon Jan 30 2023 - 17:44:17 EST


On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Is that a kernel feature or something from the MMC or SD specifications?
The former doesn't belong in DT. Set this based on the compatible string
of the controller.

>
> Signed-off-by: Hermes Zhang <chenhuiz@xxxxxxxx>
> ---
>
> Notes:
> Update commit message
>
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
> description:
> enable SDIO IRQ signalling on this interface
>
> + cap-aggressive-pm:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + enable MMC_CAP_AGGRESSIVE_PM feature
> +
> full-pwr-cycle:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.30.2
>