Re: [PATCH] [v2] vfio-mdev: add back CONFIG_VFIO dependency

From: Alex Williamson
Date: Mon Jan 30 2023 - 18:52:49 EST


On Thu, 26 Jan 2023 22:08:31 +0100
Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> CONFIG_VFIO_MDEV cannot be selected when VFIO itself is
> disabled, otherwise we get a link failure:
>
> WARNING: unmet direct dependencies detected for VFIO_MDEV
> Depends on [n]: VFIO [=n]
> Selected by [y]:
> - SAMPLE_VFIO_MDEV_MTTY [=y] && SAMPLES [=y]
> - SAMPLE_VFIO_MDEV_MDPY [=y] && SAMPLES [=y]
> - SAMPLE_VFIO_MDEV_MBOCHS [=y] && SAMPLES [=y]
> /home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld: samples/vfio-mdev/mdpy.o: in function `mdpy_remove':
> mdpy.c:(.text+0x1e1): undefined reference to `vfio_unregister_group_dev'
> /home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld: samples/vfio-mdev/mdpy.o: in function `mdpy_probe':
> mdpy.c:(.text+0x149e): undefined reference to `_vfio_alloc_device'
>
> Fixes: 8bf8c5ee1f38 ("vfio-mdev: turn VFIO_MDEV into a selectable symbol")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> v2: fix the s390 and drm drivers as well, in addition to the
> sample code.
> ---
> arch/s390/Kconfig | 4 +++-
> drivers/gpu/drm/i915/Kconfig | 1 +
> samples/Kconfig | 3 +++
> 3 files changed, 7 insertions(+), 1 deletion(-)

Applied to vfio next branch for v6.3. Thanks,

Alex