Re: [PATCH v2, RESEND] x86/efi: Safely enable unaccepted memory in UEFI

From: Dionna Amalie Glaze
Date: Tue Jan 31 2023 - 11:08:23 EST


> > + efi_status_t status;
> > +
> > + if (!IS_ENABLED(CONFIG_UNACCEPTED_MEMORY))
>
> Do we need to check for IS_ENABLED(CONFIG_AMD_MEM_ENCRYPT) here as well?
>

Arguably no, since the firmware should only make the protocol
available when it determines that the protocol should be used. In our
case, that's just SEV-SNP. The firmware's TDX logic will not expose
this protocol.

This maintains flexibility for the rare case that the TDX go-to-market
schedule doesn't align with upstream's acceptance of unaccepted memory
support, but does accept the generic TDX support. Best not paint
ourselves into a corner.

--
-Dionna Glaze, PhD (she/her)