Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus

[Krzysztof Kozlowski]

On 31/01/2023 19:10, Saurabh Sengar wrote:
> 
> Signed-off-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>

> +  - |
> +    / {
> +        compatible = "foo";
> +        model = "foo";
> +        #address-cells = <0x02>;
> +        #size-cells = <0x02>;

Except previous comments (all of them were ignored), also:
Drop entire part. Not related, not correct, not helping and you cannot
have top level nodes in example.

> +
> +        vmbus@ff0000000 {
> +            #address-cells = <0x02>;
> +            #size-cells = <0x01>;
> +            compatible = "msft,vmbus";
> +            ranges = <0x00 0x00 0x0f 0xf0000000 0x10000000>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 1f7a519a936f..ab74ea97535f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -876,6 +876,8 @@ patternProperties:
>      deprecated: true
>    "^mscc,.*":
>      description: Microsemi Corporation
> +  "^msft,.*":
> +    description: Microsoft Corporation

Don't duplicate vendor prefixes. Drop and use correct prefix.

Best regards,
Krzysztof