Re: [PATCH 15/18] lib/stacktrace, kasan, kmsan: rework extra_bits interface

[Andrey Konovalov]

On Tue, Jan 31, 2023 at 9:54 AM Marco Elver <elver@xxxxxxxxxx> wrote:
>
> > +depot_stack_handle_t stack_depot_set_extra_bits(depot_stack_handle_t handle,
> > +                                               unsigned int extra_bits);
>
> Can you add __must_check to this function? Either that or making
> handle an in/out param, as otherwise it might be easy to think that it
> doesn't return anything ("set_foo()" seems like it sets the
> information in the handle-associated data but not handle itself ... in
> case someone missed the documentation).

Makes sense, will do in v2 if Alexander doesn't object to the
interface change. Thanks!