Re: [PATCH net-next v3 4/4] selftests: net: udpgso_bench_tx: Cater for pending datagrams zerocopy benchmarking

[Willem de Bruijn]

On Tue, Jan 31, 2023 at 4:01 PM Andrei Gherzan
<andrei.gherzan@xxxxxxxxxxxxx> wrote:
>
> The test tool can check that the zerocopy number of completions value is
> valid taking into consideration the number of datagram send calls. This can
> catch the system into a state where the datagrams are still in the system
> (for example in a qdisk, waiting for the network interface to return a
> completion notification, etc).
>
> This change adds a retry logic of computing the number of completions up to
> a configurable (via CLI) timeout (default: 2 seconds).
>
> Fixes: 79ebc3c26010 ("net/udpgso_bench_tx: options to exercise TX CMSG")
> Signed-off-by: Andrei Gherzan <andrei.gherzan@xxxxxxxxxxxxx>
> Cc: Willem de Bruijn <willemb@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>

Fixes should go to net, instead of net-next.

But the code itself looks good to me.

Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>