Re: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr

[Dmitry Baryshkov]

On 07/02/2023 16:28, Vinod Polimera wrote:
> > -----Original Message-----
> > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Sent: Tuesday, January 31, 2023 6:19 PM
> > To: Vinod Polimera (QUIC) <quic_vpolimer@xxxxxxxxxxx>; dri-
> > devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx;
> > freedreno@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> > Cc: Sankeerth Billakanti (QUIC) <quic_sbillaka@xxxxxxxxxxx>; linux-
> > kernel@xxxxxxxxxxxxxxx; robdclark@xxxxxxxxx; dianders@xxxxxxxxxxxx;
> > swboyd@xxxxxxxxxxxx; Kalyan Thota (QUIC) <quic_kalyant@xxxxxxxxxxx>;
> > Kuogee Hsieh (QUIC) <quic_khsieh@xxxxxxxxxxx>; Vishnuvardhan
> > Prodduturi (QUIC) <quic_vproddut@xxxxxxxxxxx>; Bjorn Andersson (QUIC)
> > <quic_bjorande@xxxxxxxxxxx>; Abhinav Kumar (QUIC)
> > <quic_abhinavk@xxxxxxxxxxx>
> > Subject: Re: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware
> > after entering psr

Can we please get rid of this somehow?

> >   
> > On 30/01/2023 17:11, Vinod Polimera wrote:
> > > From: Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx>
> > >
> > > Updated frames get queued if self_refresh_aware is set when the
> > > sink is in psr. To support bridge enable and avoid queuing of update
> > > frames, reset the self_refresh_aware state after entering psr.
> > >
> > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx>
> > > Signed-off-by: Vinod Polimera <quic_vpolimer@xxxxxxxxxxx>
> > > ---
> > >    drivers/gpu/drm/msm/dp/dp_drm.c | 25 ++++++++++++++++++++++++-
> > >    1 file changed, 24 insertions(+), 1 deletion(-)
> >
> > As I stated in v11's discussion, I do not like the way this change plays
> > with the self_refresh_aware. Please find another way to work around the
> > timing issue (let's probably continue the discussion back in v11).
> Currently we are not able to reproduce the issue with KASAN enabled and minimum cpu frequency builds.
> We can revisit this patch if it is reproduced in future. Meanwhile I think on handling it in a different way.
> Can we not consider this patch for current merge?

Ack.

--
With best wishes
Dmitry