Re: [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header

From: Andy Shevchenko
Date: Wed Feb 08 2023 - 09:47:42 EST


On Wed, Feb 08, 2023 at 03:43:06PM +0100, Jiri Pirko wrote:
> Wed, Feb 08, 2023 at 02:31:51PM CET, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> >Move string_is_valid() to the header for wider use.
> >
> >While at it, rename to string_is_terminated() to be
> >precise about its semantics.
>
> While at it, you could drop the ternary operator and return memchr()
> directly.

Code generation will be the same, I won't modify too much the original,
the point of the change is just to have this helper to be available to
others.

> With or without it:
> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko