RE: [PATCH v2] iommu/vt-d: Avoid superfluous IOTLB tracking in lazy mode

From: Tian, Kevin
Date: Wed Feb 08 2023 - 21:10:10 EST


> From: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> Sent: Thursday, February 9, 2023 2:19 AM
>
> - iommu_iotlb_gather_add_page(domain, gather, iova, size);
> + /*
> + * We do not use page-selective IOTLB invalidation in flush queue,
> + * There is no need to track page and sync iotlb. Domain-selective or

"in flush queue, so there is ..."

> + * PASID-selective validation are used in the flush queue.

the last sentence can be removed. same meaning as the first one.

> + */
> + if (!iommu_iotlb_gather_queued(gather))
> + iommu_iotlb_gather_add_page(domain, gather, iova, size);
>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>