Re: [PATCH v4 2/2] Bluetooth: btrtl: add support for the RTL8723CS

[Vasily Khoruzhick]

On Wed, Feb 8, 2023 at 11:02 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:

Hi Marcel,

> Hi Luiz,
>
> >> The Realtek RTL8723CS is a SDIO WiFi chip. It also contains a Bluetooth
> >> module which is connected via UART to the host.
> >>
> >> It shares lmp subversion with 8703B, so Realtek's userspace
> >> initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS
> >> (CG, VF, XX) with RTL8703B using vendor's command to read the chip type.
> >
> > Don't remember anything called rtk_hciattach, besides if that is based
> > on hciattach that is already deprecated in favor of btattach.
>
> and btattach is also deprecated. Write a proper serdev based driver.

It is already a proper serdev based driver. rtk_hciattach is only
mentioned to explain how differentiating the chips was implemented
prior to this driver.

Regards,
Vasily

> The hci_ldisc line discipline crap needs to be removed.
>
> Regards
>
> Marcel
>